rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
557 stars 152 forks source link

Upgrade to a newer Google OAuth API #550

Open sffc opened 7 years ago

sffc commented 7 years ago

The current sign-in API used by Rietveld uses an older sign-in screen, which has been off-putting to some members of our team who are concerned about their account security:

Current Rietveld sign-in screen

At the bottom, it says that the application only needs your email address, but the line about "permission to access your Google account" sounds a little scary. Newer sign-in APIs have a more inviting sign-in screen:

Better sign-in screen

It would help us onboard more members of our team to Rietveld if the more modern sign-in screen were used.

cedk commented 6 years ago

This is managed by the appengine (and not the rietveld code). By the way, on my instances I got the new login page.