search

rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
557 stars 152 forks source link

support for getting access token without browser #560

Closed amandeepgautam closed 6 years ago

amandeepgautam commented 6 years ago

I have a remote VM and usually ssh to it. For sending code reviews, I have to copy and paste the access token from other browser. Looking at the code, I found that there is a TODO here to improve this experience. If anyone is willing to provide some background, I am willing to put the work in to make the changes.

amandeepgautam commented 6 years ago

ping!

andialbrecht commented 6 years ago

I don't think that it is an easy achievement. Clipboard implementations differ between the different operating systems and it would introduce dependencies to external programs. And I don't know how a clipboard implementation in upload.py could solve your issue because it couldn't access the clipboard on your host machine at all. To me the TODO you've mentioned is more an IDEA than an actual TODO.

Please have a look at #547, this should make it easier for you once it is merged.