search

rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
557 stars 152 forks source link

Use mercurial subrepos option to generate diff #568

Closed cedk closed 5 years ago

cedk commented 6 years ago

At Tryton, we started to use subrepo from mercurial but upload.py does not generate a diff for subrepo which make the review workflow less useful as we need to scatter patch in multiple reviews. So I propose to generate a diff including the subrepositories by default.

On non-subrepo, the option does nothing and on subrepo it generate a diff for all the repositories which is probably the most expected behavior.

cedk commented 5 years ago

ping @andialbrecht

andialbrecht commented 5 years ago

Thanks, @cedk !