search

riferrei / srclient

Golang Client for Schema Registry
Apache License 2.0
235 stars 70 forks source link

Enable Default Support for Protobuf #36

Closed AtakanColak closed 4 years ago

AtakanColak commented 4 years ago

By setting default codecCreation to false we can have default support for protobuf. Also added Codec generation to schema.Codec() call to make up for this change, this way overall behaviour will stay the same for avro users. Fixes #30

sashati commented 4 years ago

I'm afraid why you call it Default for Protobuf? When it seems you just disabled auto-creating for Avro.

AtakanColak commented 4 years ago

@sashati by disabling default avro codec creation, we stop default client from trying to create protobuf avro codecs.

sashati commented 4 years ago

Thanks @AtakanColak for the reply. I get the point. Well, maybe here is not a good place to ask. But I didn't find any place in the code to deal with Protobuf codes. Seems the Schema object is just Avro and adding Protobuf support needs a significant change in this codebase. Do you have any idea/sample code how to use it. Or is there any active development on Protobuf? I would love to contribute

AtakanColak commented 4 years ago

@sashati My experience with schema registry was unfortunately limited to Avro. Issues #16 and #17 would be the best place to discuss Protobuf. Any contribution would be surely welcome.