search

riferrei / srclient

Golang Client for Schema Registry
Apache License 2.0
235 stars 70 forks source link

Missing field in GetSchema #79

Closed lotus-x closed 2 years ago

lotus-x commented 2 years ago

Hi,

I think References field must be included when constructing the Schema which is fetched using a schema ID

https://github.com/riferrei/srclient/blob/master/schemaRegistryClient.go#L226

Also I checked with the confluent's schema registry, and it does return the references for the request /schemas/ids/%s

AtakanColak commented 2 years ago

This is a trivial addition, but I want to combine this feature with a test suite I'm workıng on for this library on Github Actions. I don't have a reliable way to test this immediately, if someone can verify the one line change has no bugs for when there are no references, please let me know.

AtakanColak commented 2 years ago

Resolved in #89