search

riferrei / srclient

Golang Client for Schema Registry
Apache License 2.0
235 stars 70 forks source link

GetSchema() call does not return schema references as part of the return Schema #87

Closed mdpaquin closed 2 years ago

mdpaquin commented 2 years ago

While it works fine when fetching a Schema by Subject/Version pair, fetching a Schema by ID does not currently return the linked references. I have PR ready with the fix.

AtakanColak commented 2 years ago

Hi, thank you for your contribution, I'm unable to see the PR, could you create a new pull request?

mdpaquin commented 2 years ago

Hello @AtakanColak, I am currently unable to push my branch to open a PR as I am not a collaborator. Can you give me the necessary permissions?

AtakanColak commented 2 years ago

You don't need to push your branch to this repository to open a PR to this repository.

mdpaquin commented 2 years ago

@AtakanColak sorry, did everything locally, did not initially bother forking. Here is the PR:

https://github.com/riferrei/srclient/pull/89

AtakanColak commented 2 years ago

Closed as PR is approved