search

riferrei / srclient

Golang Client for Schema Registry
Apache License 2.0
235 stars 70 forks source link

CreateMockSchemaRegistryClient gives no codec #92

Closed survivorbat closed 1 year ago

survivorbat commented 2 years ago

Hey there,

Loving this library so far, really like that you put thought in using interfaces and mocks, can't express how happy I am that you added those.

One thing I'm struggling with though is that in the following example Codec() is nil.

image image

I'm expecting to be able to unit-test the example code, but the Codec is never set or supplied. Am I missing something obvious? Or am I meant to exclude the codec stuff for testing purposes only? I hope not.

Yours sincerely,

Alex

survivorbat commented 2 years ago

I made #94 to take care of both this issue and another one concerning GetSchemaVersion not working properly.

ahernandez9 commented 1 year ago

@riferrei Is there any plan to launch a new version? Like 0.5.5 or 0.6 stable. It'd be nice to be able to use this contribution by @survivorbat in our unit tests without having to use master in our codebase. Thanks! :)

AtakanColak commented 1 year ago

Hi, I should launch a new version once #98 is merged.

AtakanColak commented 1 year ago

New version has been released, closing this issue