search

rifflearning / zenhub

This is the master repository for the Riff Projects in our ZenHub Workspace
0 stars 0 forks source link

Dashboard lists/shows meeting w/ only you #134

Open mlippert opened 5 years ago

mlippert commented 5 years ago

The My Riffs page list of meetings includes meetings in which you were the sole participant.

Steps to Reproduce

Have a meeting w/ only yourself. It must be a meeting that lasts longer than 2 minutes. I'm not 100% sure how to create a meeting w/ only yourself.

Leave the meeting and go to the My Riffs page. You will see the meeting with metrics which only include you.

Expected behavior

Meetings w/ only yourself are uninteresting and are expected to be filtered out of the meeting list.

Context

Screenshots

image

Site the bug occurred on:

localhost (development machine)

Additional context

This is happening in my feature branch based on riff-rtc version 1.2.0-dev.5. I tested this back to version 1.2.0-dev.1 where it still happens.

mlippert commented 5 years ago

A little more research shows that there was actually a 2nd participant in this meeting, you can see the participantEvent object where they joined and later left: image

There is even a TODO comment in the code that I didn't realize was about this exact situation.

Therefore, this is going to require more design thought on what we want to present to the user. I believe that the 2nd user joined but had zero utterances in the meeting, and the displayed metrics (such as attendees and who is shown on the timeline) are based around the utterance data.

I think we should show 2 attendees in this case, and also the participant w/ no utterances should still be present on the timeline (I'm not sure if they should also be in the turn chart).