rifflearning / zenhub

This is the master repository for the Riff Projects in our ZenHub Workspace
0 stars 0 forks source link

EDU dashboard breaks if user has first meeting by themselves #177

Open adonahue opened 4 years ago

adonahue commented 4 years ago

From @jordanreedie via the #defects channel:

https://github.com/rifflearning/mattermost-webapp/blob/42233716cfe1aec410e79fc5bacbd75f59b9366c/actions/views/dashboard.js#L164 actions/views/dashboard.js:164 err.message === 'no meetings after nparticipants filter' https://github.com/rifflearning/mattermost-webapp|rifflearning/mattermost-webapprifflearning/mattermost-webapp | Added by GitHub does not match the error thrown: https://github.com/rifflearning/mattermost-webapp/blob/42233716cfe1aec410e79fc5bacbd75f59b9366c/actions/views/dashboard.js#L132 actions/views/dashboard.js:132 throw new Error('no meetings after participants filter'); https://github.com/rifflearning/mattermost-webapp|rifflearning/mattermost-webapprifflearning/mattermost-webapp | Added by GitHub

results in the dashboard breaking if the condition in which that error is thrown occurs (if the user has joined a video chat meeting by themselves, and no one else has joined them ever) ex: it's my first time using riff edu. i try to start a meeting, no one joins. If i then visit the dashboard, it's just blank this bug will only occur if the user has never been in a meeting with another user, and they have tried to start a meeting at least once

adonahue commented 4 years ago

verified - staging / chrome.