Dashboard Notes - Githubissues

rifflearning / zenhub

This is the master repository for the Riff Projects in our ZenHub Workspace

0 stars 0 forks source link

Dashboard Notes #241

Open adonahue opened 4 years ago

adonahue commented 4 years ago

Timeline

[x] X axis should be in 12-hour clock times, so that it matches the time display in tool tip and other meeting time displays.
[x] Change tool tip from "utterance by {usrname}" to "{username}: {(calculate time) mm:ss}

Other

[ ] Interruptions card back text is too small.
[x] Change paired tool tips to "You interrupted them" and "They interrupted you" or "You interrupted" and "Interrupted you" ??? Or can we do names? e.g. "Beth interrupted you: 2" and "You interrupted Mike: 1"
[x] When there is no data, always turn off the legend by default.

All

[x] Change all graph titles to color #576066
[x] When metrics are scrolled down, and a meeting is selected from further down the navigation, is it possible to reset the metrics at the top of the page?

brecriffs commented 4 years ago

@adonahue I forget where we landed in our conversation regarding 'Interruptions card back text is too small.'. Also I am not sure what 'Remove hundredths of a second from the tool tip.' is referencing, but I think all the tooltips make sense now. Let's get this on dev for a last QA round. I will do a PR for #245 in the next day or so, which will address all of the related cards.

adonahue commented 4 years ago

@brecriffs -

Interruptions text - you were going to play with the padding / margins a little and see if the text size could be enlarged and still stay in the box. If not possible, leave as is.
For the tool tip, see image

brecriffs commented 4 years ago

@adonahue Okay I will see what I can do for the text. For the tooltip, those are actually seconds. I think it makes sense to keep them, but up to you.

adonahue commented 4 years ago

@brecriffs - oh, I see now, sorry about that. Yes, agree they should stay.

brecriffs commented 4 years ago

PR posted and attached to #154

adonahue commented 4 years ago

Verified in chrome. Card back text is still smaller than desired, and it looks like there is still whitespace to "use". Spoke to @brecriffs about the options for this and accepting story as-is.