Code Review: Chat Refactor

rifflearning / zenhub

This is the master repository for the Riff Projects in our ZenHub Workspace

0 stars 0 forks source link

Code Review: Chat Refactor #80

Open jordanreedie opened 5 years ago

jordanreedie commented 5 years ago

Code Review Time Tracking card for story riff-rtc#96 (PR rifflearning/riff-rtc#129 Refactor Chat pt2)

mlippert commented 5 years ago

So far about 1.5 hours

mlippert commented 5 years ago

Another .5 hours

adonahue commented 5 years ago

@mlippert and @jordanreedie - Can this story be closed out? It sounded like the review is done.

@mlippert I'm guessing this took more than 2 hours - did you track your time somewhere else?

adonahue commented 5 years ago

Nevermind @mlippert I found them on PR #129.

jaedoucette commented 5 years ago

@jordanreedie It looks like this story was linked to zenhub card #96, but that card is about Qualtrics surveys. Probably this should point somewhere else?

mlippert commented 5 years ago

I was wondering what this story was when I got the email comment on it. Yes my code review time is in a couple of comments on the PR riff-rtc#129. That PR is attached to the story riff-rtc#96 which was obviously created before we realized we needed to keep all stories in the zenhub repo.

My Code Review Time on PR riff-rtc#129:

7/16 - 2.5 hrs
7/18 - 2.5 hrs
7/19 - 5 hrs
7/22 - 5.5 hrs
7/23 - 1.5 hrs
7/26 - 1 hr (final, code was merged after this) Total 18 hrs Oh I missed the 2 hours I listed above from June, so Total 20 hrs

adonahue commented 5 years ago

This code is merged, I believe. @mlippert @juliariffgit - can this be closed?

mlippert commented 5 years ago

fine by me

juliariffgit commented 5 years ago

and me!

On Tue, Jul 30, 2019 at 10:28 AM Mike Lippert notifications@github.com wrote:

fine by me

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rifflearning/zenhub/issues/80?email_source=notifications&email_token=AL4S64JKXJISVEKFGZZSMO3QCBFY3A5CNFSM4H3AODSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3EE6MQ#issuecomment-516443954, or mute the thread https://github.com/notifications/unsubscribe-auth/AL4S64NC2BURFMXMFSATI5TQCBFY3ANCNFSM4H3AODSA .

-- Julia Henderson Project Manager & Scrum Master, Riff Learning julia@rifflearning.com 617.871.9104