search

riga / law

Build large-scale task workflows: luigi + job submission + remote targets + environment sandboxing using Docker/Singularity
http://law.readthedocs.io
BSD 3-Clause "New" or "Revised" License
96 stars 39 forks source link

Don't print "...and 1 more" when remote jobs fail #136

Closed lmoureaux closed 1 year ago

lmoureaux commented 1 year ago

In a variety of situations, Law prints the status of the first few job followed by ...and N more. It adds the ...and N more even when N is 1 and printing the extra job would have taken as much space as the ...and 1 more line.

I think code like this could account for the extra line by checking i + 2 instead of i + 1: https://github.com/riga/law/blob/70a223f57512e9e3e377a27709ad74067dacf07f/law/workflow/remote.py#L832-L838

riga commented 1 year ago

I think this should be done together with #135, increasing the threshold by 1 as you proposed.

lmoureaux commented 1 year ago

Works great!