search

riga / law

Build large-scale task workflows: luigi + job submission + remote targets + environment sandboxing using Docker/Singularity
http://law.readthedocs.io
BSD 3-Clause "New" or "Revised" License
98 stars 41 forks source link

Fix for Dockerfile smell DL3048 #152

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Hi! The Dockerfile placed at "docker/Dockerfile_centos7_py38" contains the best practice violation DL3048 detected by the hadolint tool.

The smell DL3048 occurs when the pattern used for the label keys does not match the format recommended by official guidelines. In this pull request, we propose a fix for that smell generated by our fixing tool. We manually checked that the patch is correct before opening the pull request. To fix this smell, specifically, the label keys are refactored to match the correct format.

This change is only aimed at fixing that specific smell. In the case the fix is not valid or useful, please briefly indicate the reason along with suggestions for possible improvements.

Thanks in advance.

riga commented 1 year ago

Thanks for opening the PR!

I wasn't aware of the label key format. Merging right away :+1: