riga / law

Build large-scale task workflows: luigi + job submission + remote targets + environment sandboxing using Docker/Singularity
http://law.readthedocs.io
BSD 3-Clause "New" or "Revised" License
96 stars 39 forks source link

Examples with Docker image: container exits immediately #154

Closed joschkabirk closed 1 year ago

joschkabirk commented 1 year ago

Bug description

I noticed that when running the examples as documented e.g. here (i.e. by running docker run -ti riga/law:example workflows), the container exits immediately.

I think this is due to this line in the start_example.sh, where the last command is bash -i --login.

The resulting error is then bash: --: invalid option. Maybe this should be changed to just bash --login?

Full log ```bash $ docker run -ti riga/law:example workflows WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested running law example 'workflows' in /root/law/examples/workflows Cloning into '/root/law/examples/workflows/tmp/luigi'... remote: Enumerating objects: 20703, done. remote: Counting objects: 100% (88/88), done. remote: Compressing objects: 100% (72/72), done. remote: Total 20703 (delta 40), reused 40 (delta 15), pack-reused 20615 Receiving objects: 100% (20703/20703), 10.54 MiB | 16.79 MiB/s, done. Resolving deltas: 100% (14404/14404), done. Note: switching to 'tags/2.8.13'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false HEAD is now at 54a34736 Version 2.8.13 Cloning into '/root/law/examples/workflows/tmp/six'... remote: Enumerating objects: 1912, done. remote: Counting objects: 100% (55/55), done. remote: Compressing objects: 100% (29/29), done. remote: Total 1912 (delta 28), reused 44 (delta 24), pack-reused 1857 Receiving objects: 100% (1912/1912), 1.72 MiB | 11.01 MiB/s, done. Resolving deltas: 100% (1138/1138), done. law example 'workflows' successfully set up browse through the README file for further info bash: --: invalid option Usage: bash [GNU long option] [option] ... bash [GNU long option] [option] script-file ... GNU long options: --debug --debugger --dump-po-strings --dump-strings --help --init-file --login --noediting --noprofile --norc --posix --rcfile --rpm-requires --restricted --verbose --version Shell options: -ilrsD or -c command or -O shopt_option (invocation only) -abefhkmnptuvxBCHP or -o option ```
riga commented 1 year ago

Thanks @joschkabirk for opening this issue!

You might be right! I'm going to have a look asap.