search

riga / law

Build large-scale task workflows: luigi + job submission + remote targets + environment sandboxing using Docker/Singularity
http://law.readthedocs.io
BSD 3-Clause "New" or "Revised" License
96 stars 39 forks source link

Fix TypeError causing function call #175

Closed HerrHorizontal closed 3 months ago

HerrHorizontal commented 3 months ago

Class instance self was given as positional argument although req_workflow is a class method with native access to self. This wasn't a problem with the previous implementation using req directly without the new helper method req_workflow introduced in commit https://github.com/riga/law/commit/7d4f6793baff103cd69bf6c88ac446ffb37a3402#diff-797a1ce240571ca7714bd6fb314f3eaa3e1e241982c9a8ee48cdfbf6e4c72394L1025-R1056.

riga commented 3 months ago

Indeed, thanks for the fix @HerrHorizontal 🎉