search

riga / law

Build large-scale task workflows: luigi + job submission + remote targets + environment sandboxing using Docker/Singularity
http://law.readthedocs.io
BSD 3-Clause "New" or "Revised" License
98 stars 41 forks source link

Fix implementation of WrapperTask and ExternalTask #42

Closed lgeiger closed 6 years ago

lgeiger commented 6 years ago

Problem

luigi treats tasks without a run method as external Tasks and therefor won't run them if dependencies are missing.

Proposed Solution

This PR fixes the implementation of WrapperTask to match luigi: see luigi.WrapperTask and luigi.Task::run().

I also added the ExternalTask class the same way as defined in luigi and modified law.cli.db to include external tasks in the completions.