rigaya / NVEnc

NVENCによる高速エンコードの性能実験
https://rigaya34589.blog.fc2.com/blog-category-17.html
Other
1.07k stars 112 forks source link

Encoding will abort when using `--vpp-nnedi` together with `--vpp-denoise-dct` #559

Closed quamt closed 7 months ago

quamt commented 7 months ago

Hello @rigaya,

when using --vpp-nnedi together with --vpp-denoise-dct the encoding will abort: Using interlaced input material.

Error message:

cspconv: unsupported interlaced csp conversion: yv12(16bit) -> rgb(fp32).
denoise-dct: Error while running filter "cspconv".
denoise-dct: error at denoise: yv12(16bit).
Error while running filter "denoise-dct".
rigaya commented 7 months ago

Thank you for the report, I was able to reproduce the issue. I'll have this fixed in the next release.

quamt commented 7 months ago

Thank you. I apologize for not mentioning earlier that when you mistakenly type the wrong number in --vpp-denoise-dct option, it displays incorrect option values in the error message.

Example:

Error: Invalid value "9" for "--vpp-denoise-dct step="
  Option value should be one of below...
    auto, fp32, fp16

Error: Invalid value "15" for "--vpp-denoise-dct block_size="
  Option value should be one of below...
    auto, fp32, fp16
rigaya commented 7 months ago

Thank you for also letting me know the wrong error message.

The issue using vpp-nnedi and vpp-denoise-dct together, and also the wrong step and blocksize message should have been fixed in NVEnc 7.42.

quamt commented 7 months ago

Thank you very much for your excellent work.

When using the options --vpp-nnedi and --vpp-denoise-dct together, the encoding process works smoothly. The error messages that display the option values are great as well.

Error: Invalid value "9" for "--vpp-denoise-dct step="
  Option value should be one of below...
    1, 2, 4, 8
Error: Invalid value "15" for "--vpp-denoise-dct block_size="
  Option value should be one of below...
    8, 16    

I am going to close this issue as the problem has been fixed.