search

rigaya / NVEnc

NVENCによる高速エンコードの性能実験
https://rigaya34589.blog.fc2.com/blog-category-17.html
Other
1.03k stars 108 forks source link

Fix English --lookahead-level description #575

Closed Dendraspis closed 2 months ago

Dendraspis commented 2 months ago

I can't read Japanese, but it seems to state 0 as the default value, so I guess this should be correct.

rigaya commented 2 months ago

Thank you for the pull request, but --lookahead-level is defaulted to auto (when unspecified), and not 0. (same in Japanese)

So unfortunately I'm sorry but I must say that no fix is required here.

Dendraspis commented 2 months ago

No problem, just want to help. But what is the default value as auto is not an <int>? Can it be only applied by not setting the parameter at all? That's what's unclear as all other parameters have a specific default value.

rigaya commented 2 months ago

Can it be only applied by not setting the parameter at all?

Yes, just don't set anything.

You can set --lookahead-level auto as special value, but I didn't bother writing it, not setting anything is easier.

Dendraspis commented 2 months ago

Oh, okay, I was just surprised because this is completely different than usual behavior.

Thanks for the clarification. So I'll close this now.....