rigaya / NVEnc

NVENCによる高速エンコードの性能実験
https://rigaya34589.blog.fc2.com/blog-category-17.html
Other
1.09k stars 114 forks source link

When set option fps, master-display copy option doesnt work #640

Closed bitspyer closed 2 weeks ago

bitspyer commented 3 weeks ago

Dont know if this is a bug or a feature:

When using the --fps option AND the option
--master-display copy the Master Display Value from the Source will not copied to the Encoded File.

rigaya commented 2 weeks ago

--master-display copy is not intended to be used with --fps, and might run into unexpected results.

--fps is for raw format reader, and not intended for --avsw/--avhw reader.

--master-display copy should require --avsw/--avhw reader, and it can get framerate from the input file, so please remove --fps.

bitspyer commented 2 weeks ago

ok... I thought so would you please add this to the Documentation?

rigaya commented 2 weeks ago

I have updated the docs mentioning that --fps should be only used with --raw. https://github.com/rigaya/NVEnc/blob/master/NVEncC_Options.en.md#--fps-intint-or-float

bitspyer commented 2 weeks ago

Great!