rigaya / QSVEnc

QSVによる高速エンコードの性能実験
http://rigaya34589.blog135.fc2.com/blog-category-10.html
Other
314 stars 28 forks source link

Question about --vpp-nlmeans fp16 parameter settings and errors #197

Closed quamt closed 5 months ago

quamt commented 5 months ago

Hello @rigaya,

I'm currently using the --vpp-nlmeans feature and have some questions regarding the fp16 parameter options. While integrating this into my workflow, I’ve run into a few confusing points concerning the parameter values and their documentation.

Documentation on fp16Settings: According to the documentation, the options for fp16include: none: Uses fp32for higher precision but slower performance blockdiff: Uses fp16in block difference calculations for a balance between performance and precision fp16: Uses fp16in weight calculations for faster performance but lower precision

Encountered Errors: When I set the fp16parameter using --vpp-nlmeans fp16=fp16, I receive the following error:

Error: Invalid value "fp16" for "--vpp-nlmeans fp16="
Option value should be one of below...
  auto, fp32, fp16

Interestingly, when I tryfp16=auto, which the error message suggests as a valid option, I get a similar error. This option (auto) isn’t listed in the initial documentation.

Confusion with Parameter Values:

It appears that the valid options listed in the error messages do not entirely match what’s in the documentation. Also, while none and blockdiffwork as expected, they are not mentioned in the error message as valid values.

Thanks a lot for your help and the awesome work on this tool!_

rigaya commented 5 months ago

"fp16" is written wrong and should be "all", so --vpp-nlmeans fp16=<x> should take "none", "blockdiff" and "all".

I'll fix the help in next release.

rigaya commented 5 months ago

Online document has be fixed for --vpp-nlmeans fp16.

quamt commented 5 months ago

Thank you for your feedback. I will now mark this issue as resolved and close it.