search

rigdenlab / SIMBAD

Sequence Independent Molecular replacement Based on Available Database
http://simbad.rtfd.io
BSD 3-Clause "New" or "Revised" License
3 stars 7 forks source link

Fix for running on windows where each command in a batch script that … #58

Closed linucks closed 6 years ago

linucks commented 6 years ago

…calls another batch script needs to be prefixed with 'call'

This hasn't been tested as I couldn't find any tests that called the relevant bit of code

hlasimpk commented 6 years ago

@linucks This looks like it should work. There are a few other areas where we generate and run scripts (e.g. the rotsearch stuff), however MR/refinement is the only place where we have more than 1 program called from a single script. Therefore I think this is the only place we need to add the 'call' prefix.

If you run any of the example cases in the simbad/examples folder, they should call the relevant code by default. If they work on Windows with these changes I'm happy to merge.

linucks commented 6 years ago

Unfortunately I won't be able to check this on a Windows machine for at least a week, but the code is doing what I think it should and doesn't break on OSX, so I think it's probably ok to merge?

hlasimpk commented 6 years ago

That's true, I have a windows machine at home so I will have a look at testing it there this evening