search

rigdern / pineapple

5 stars 0 forks source link

GUI code too procedural, not OOP #13

Closed Lithium3 closed 14 years ago

Lithium3 commented 14 years ago

User interaction, config file i/o, gui elements very tightly coupled. conf.py getting very large and while it generally "works," should reorganize code somewhat before code review. Currently numerous GUI elements are global in order for them to be referenced elsewhere in the code.

Perhaps GUI interaction can be pulled into its own class in a separate file. Ultimately they will want to see code that is more object oriented than what we have now (also gives more material for class diagrams). Might be able to use a "mediator" design pattern here as well.

Lithium3 commented 14 years ago

Improved in latest version. May try to break up role model window into its own class as well, if time.

Lithium3 commented 14 years ago

Fixed.