search

rigelhope / omnidroid

Automatically exported from code.google.com/p/omnidroid
Apache License 2.0
0 stars 0 forks source link

adding cancel/back buttons #110

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
adding cancel/back buttons

Original issue reported on code.google.com by sv767%ny...@gtempaccount.com on 4 Jul 2010 at 6:18

GoogleCodeExporter commented 8 years ago

Original comment by sv767%ny...@gtempaccount.com on 4 Jul 2010 at 2:54

GoogleCodeExporter commented 8 years ago

Original comment by case.and...@gmail.com on 6 Jul 2010 at 2:19

GoogleCodeExporter commented 8 years ago 
There used to be a bunch of "cancel" buttons several revisions ago on the Dlg 
Activities.  I took them out because the phone already has a "back" button 
built in and it seemed redundant.  I removed them with the idea of streamlining 
the UI.  That doesn't mean I'm completely opposed to the idea of having some 
cancel/back buttons, but I'd be interested in what activities you think should 
have cancel buttons and the rational behind having them.

Original comment by case.and...@gmail.com on 6 Jul 2010 at 2:39

GoogleCodeExporter commented 8 years ago 
ones that have space for button, choose root event for instance. personally, I 
always use back button on my screen, rather than the other back button.

say, you might accidentally press create rule button in ActivityMain, then you 
wanna click go back, that feels like leaving the application. I would def add 
cancel buttons to choose filters screen; in event log, when window with 
additional info pops up, you need something either ok or something to finish 
it; in general places that allow this, even in saved rules activity, you don't 
have anything there, so why not?

Original comment by sv767%ny...@gtempaccount.com on 6 Jul 2010 at 4:27

GoogleCodeExporter commented 8 years ago 
I don't think I agree.  The only time I can think of that that I think having a 
Cancel button would be if the changes made are effective immediately and you 
want to revert the changes you've made.  Our app doesn't do that.

Having back/cancel buttons doesn't add any functionality as the phone already 
has that button on all screens.  You wouldn't put 2 back/cancel buttons on the 
screen, why add it here unless the functionality is different than the phone's 
back button?

As for putting it on the Root Event screen, that button bar needs to be removed 
completely in favor of just clicking on an item.  There is no need for the OK 
button on that screen.  I opened Issue #113 about this.

Original comment by case.and...@gmail.com on 6 Jul 2010 at 1:35

GoogleCodeExporter commented 8 years ago 
well I like having back button on the screen and as i said I use it on my phone 
all the time even though my phone has back button as well, and it's right next 
to screen's back button most of the time.

Original comment by sv767%ny...@gtempaccount.com on 6 Jul 2010 at 1:56

GoogleCodeExporter commented 8 years ago

Original comment by sv767%ny...@gtempaccount.com on 6 Jul 2010 at 1:58

GoogleCodeExporter commented 8 years ago 
but whatever you say

Original comment by sv767%ny...@gtempaccount.com on 6 Jul 2010 at 1:59

GoogleCodeExporter commented 8 years ago 
I'm open for discussion.  Can you poll the developers in class and see what 
they think?  If we decide to re-implement these, the code was removed in r762.

Original comment by case.and...@gmail.com on 6 Jul 2010 at 3:48

GoogleCodeExporter commented 8 years ago

Original comment by sv767%ny...@gtempaccount.com on 7 Jul 2010 at 2:27