rigelhope / omnidroid

Automatically exported from code.google.com/p/omnidroid
Apache License 2.0
0 stars 0 forks source link

web page action fails to load urls without http #138

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1.open rule with show web page action
2.dont' include http in url.
3.trigger the rule

What is the expected output? What do you see instead?
web page is not loaded

solution: we need to add http to urls.

This shouldn't be hard to do, I's say it makes sense, ppl arn't used to typing 
http in browser, so it could happen a lot.

Original issue reported on code.google.com by sv767%ny...@gtempaccount.com on 24 Jul 2010 at 3:29

GoogleCodeExporter commented 8 years ago
why don't we use browser to display the web page?

andrew, any idea why it was done this way initially?

Original comment by sv767%ny...@gtempaccount.com on 24 Jul 2010 at 5:58

GoogleCodeExporter commented 8 years ago
No idea.  It obviously should use the web browser instead.  If we use the 
browser instead it actually may fix this bug for us.

Original comment by case.and...@gmail.com on 24 Jul 2010 at 1:58

GoogleCodeExporter commented 8 years ago
unfortunately it doesn't fix the problem.

if we add http after user inputs url, we need to check whether url includes 
http or not, and also we need to detect cases like htp:// or small mistakes 
like that.

alternatively we could have http:// already put in url field.

Original comment by sv767%ny...@gtempaccount.com on 25 Jul 2010 at 6:41

GoogleCodeExporter commented 8 years ago

Original comment by sv767%ny...@gtempaccount.com on 25 Jul 2010 at 8:43

GoogleCodeExporter commented 8 years ago
I think auto-correcting htp:// maybe a bit overboard (even mozilla doesn't do 
it).

I just noticed that the show website activity called by the action looks a bit 
different from the browser activity that can be called from the quick launch. 
Maybe we could just use this instead...

Original comment by renc...@gmail.com on 25 Jul 2010 at 11:31

GoogleCodeExporter commented 8 years ago

http://codereview.appspot.com/1898041/show 

Original comment by sv767%ny...@gtempaccount.com on 25 Jul 2010 at 11:46

GoogleCodeExporter commented 8 years ago

committed r831

Original comment by sv767%ny...@gtempaccount.com on 26 Jul 2010 at 10:29