search

rigelhope / omnidroid

Automatically exported from code.google.com/p/omnidroid
Apache License 2.0
0 stars 0 forks source link

Consistent Capitalization in Events/Filters/Actions #160

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 

Capitalization in Event/Action/Filter names should be consistent (only 
capitalize the first word?)

Original issue reported on code.google.com by case.and...@gmail.com on 2 Aug 2010 at 12:09

GoogleCodeExporter commented 8 years ago 
I think what really need to happen here is separation of the human readable 
version of Events/Applications/Actions/Filters/Attributes/etc. from the 
omnidroid used key for these entries.

For example, the EVENT_NAME="GMAIL Send" which uniquelly identifies this event 
is currently being used to display this information to the user and is also the 
key in the database for this event.

What I propose is that we keep the EVENT_NAME="GMAIL Send" as the database key 
(so we don't have to update the DB), but each event also has a human readable 
string such as:
  EVENT_NAME_DISPLAYED=getString(R.strings.event_name_gmail_send)
which corresponds to "Gmail send email" or something similar in strings.xml

We would need to do this with all the data types, events, actions, filters, etc.

Other suggestions?

Original comment by case.and...@gmail.com on 2 Aug 2010 at 4:26

GoogleCodeExporter commented 8 years ago 
If we can afford to reset the DB, I would prefer the keys to be an enum 
instance that has a long value over String...

Original comment by renc...@gmail.com on 2 Aug 2010 at 6:29

GoogleCodeExporter commented 8 years ago

Original comment by case.and...@gmail.com on 6 Aug 2010 at 12:28