search

rigertd / LegacyMUD

A multi-user dungeon engine developed in C++.
Other
0 stars 0 forks source link

DataManager does not provide a way of determining the starting area #6

Closed rigertd closed 7 years ago

rigertd commented 7 years ago

When loading game data, GameLogic needs to know the ID of the starting area. Can you add something to the Area serialization and deserialization so that GameLogic can query this information through a DataManager function?

keithadkins commented 7 years ago

This is a game logic issue. This needs to be reassigned to Rachel.

rigertd commented 7 years ago

No, this is a data manager issue. The starting area is assigned to the GameLogic::startArea member variable. The DataManager class does not provide a way to get this information from the deserialized data. Refer to Rachel's last comment in #1.

keithadkins commented 7 years ago

It sounds like Rachel needs to help you out here. Once again, this is a game logic issue. Clearly, the game logic should choose what the starting area is.

rigertd commented 7 years ago

Do you want me to guess that it is the first area? I can totally guess a random area, but that's not exactly good design. The serialized data needs to store the starting area ID.

rigertd commented 7 years ago

Since you seem to be too busy to add this feature, I did it for you. Please review the changes in PR #7.

keithadkins commented 7 years ago

Oh I see what you're saying. This is a design preference for you.
My position stands: if it is not a show stopper issue, I have no bandwidth to address your issues. Here's a solution that will work for you: Hard code the starting area in the code to id #0. You're change request in the DataManager class is rejected. I am not introducing design preference changes at this point due to the risk of introducing bugs.

Ok. Checking out now,

rigertd commented 7 years ago

This is not a design preference. It is a requirement in the Software Project Plan, 4.1.7.1:

This is impossible to implement if we hard code it as Area ID 0.

keithadkins commented 7 years ago

And the overall project requirements which trumps your desire to have the project plan dictate all: "You won't be required to conform to exactly what you submit during with this Project Plan. "

Plus, who our client is: "In this process, I (the Instructor) play two roles: the facilitator for the course work, and the "Client" for your projects."

Please shift all issues concerns to Canvas. The github issues tracker has proven to not be very productive. I'll only be monitoring Canvas from here on out.