search

rigetti / grove

Quantum algorithms built using pyQuil.
http://rigetti.com/forest
Apache License 2.0
375 stars 123 forks source link

Make grove/alpha/ modules pyQuil2.0 compatible #190

Closed amyfbrown closed 5 years ago

amyfbrown commented 5 years ago

@ntezak, thanks for explaining the semaphore failure. This is my first time working with it.

Regarding the tomography failures, those tests were purposefully left to be dealt with last since @marcusps and @mpharrigan feel that tomography should live in the QCVV library rather than in grove, so the tomography code might be removed from grove altogether. In order to deal with all other issues first, I commented out everything from grove/tests/tomography/ before running pytest --cov=grove, which gave me no failures.

How do you suggest I deal with these tomography tests for the time being, @ntezak? Should I simply push with the tests commented out? That seems hacky, and I'm reluctant to delete them entirely without a separate discussion.

ntezak commented 5 years ago

@amyfbrown instead of commenting out, feel free to modify the py.test [...] call in tox.ini by appending --ignore=PATH/TO/TOMOGRAPHY

amyfbrown commented 5 years ago

@ntezak, I was hoping for an elegant solution like that. Perfect!