rigetti / pyquil

A Python library for quantum programming using Quil.
http://docs.rigetti.com
Apache License 2.0
1.4k stars 342 forks source link

fix: DefFrame no longer attempts to serialize HARDWARE-OBJECT as json. #1715

Closed MarquessV closed 9 months ago

MarquessV commented 9 months ago

Description

Closes #1711

I also updated the docstring on get_calibration_program to warn about potentially surprising behavior with returning a cached reference.

Checklist

rigetti-githubbot commented 9 months ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7053 6186 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/api/_compiler.py 56% 🟢
pyquil/quilbase.py 93% 🟢
TOTAL 74% 🟢

updated for commit: 2a03a75 by action🐍

notmgsk commented 9 months ago

Isn't the example in #1711 a repro test case?

MarquessV commented 9 months ago

Isn't the example in #1711 a repro test case?

I copied it from an external report which doesn't include the specific frame they were trying to identify. I'm making the assumption that it was a json string, but I don't know for sure.