rigetti / qcs-sdk-rust

Rust SDK for Rigetti Quantum Cloud Services (QCS)
https://docs.rs/qcs
13 stars 5 forks source link

fix!: use crate-defined translation options #379

Closed jselig-rigetti closed 1 year ago

jselig-rigetti commented 1 year ago

Seems that it was intended to require the crate's wrapper for TranslationOptions, otherwise the consumer needs to separately install qcs-api-client-grpc to call submit_to_qpu https://github.com/rigetti/qcs-sdk-rust/blob/6416c87861583ee0ea0f5ff66c4daa049ac4f14b/crates/lib/src/executable.rs#L540

https://github.com/rigetti/qcs-sdk-rust/blob/c6ec8c4271b6c01c620974722e10d31684b58416/crates/lib/src/qpu/translation.rs#L120

This change will bring things in-line with the python counterpart https://github.com/rigetti/qcs-sdk-rust/blob/c6ec8c4271b6c01c620974722e10d31684b58416/crates/python/src/qpu/translation.rs#L172 https://github.com/rigetti/qcs-sdk-rust/blob/c6ec8c4271b6c01c620974722e10d31684b58416/crates/python/src/qpu/translation.rs#L109