search

rigetti / rpcq

The RPC framework and message specification for @rigetti Quantum Cloud Services.
Apache License 2.0
75 stars 29 forks source link

Fix tests on Python 3.7+ due to change in BaseException.__repr__ #124

Closed appleby closed 4 years ago

appleby commented 4 years ago

In #120 we switched from str to repr for printing exceptions, which broke the python tests on 3.7+ due a change in python's default BaseException.__repr__, which dropped the trailing comma.

https://docs.python.org/3/whatsnew/3.7.html#changes-in-the-python-api

This PR also updates .gitlab-ci.yaml to run the pytests on all supported Python versions (3.6, 3.7, and 3.8)

appleby commented 4 years ago

New chonkier gitlab pipline results here:

https://gitlab.com/rigetti/forest/rpcq/pipelines/121722722

notmgsk commented 4 years ago

@stylewarning looks like you're the only account that can actually approve.