search

rigetti / rpcq

The RPC framework and message specification for @rigetti Quantum Cloud Services.
Apache License 2.0
75 stars 29 forks source link

Correctly report timeout in errors #144

Closed notmgsk closed 3 years ago

notmgsk commented 3 years ago

Due to a scoping issue, timeouts were reported with the server's timeout, rather than the client's (if it was provided).

erichulburd commented 3 years ago

What do you mean by report? This effectively shortens the timeout for apply-handler if the client timeout < server timeout right?

notmgsk commented 3 years ago

What do you mean by report? This effectively shortens the timeout for apply-handler if the client timeout < server timeout right?

Yes, and that was the case prior to this PR. Unfortunately, prior to this PR, when a timeout was hit RPCQ would issue an error message that used the server's timeout rather than the client's timeout. So the client might see a misleading message (client provides a timeout but sees a different timeout in the error message).