search

rightfold / purescript-bytestrings

Immutable packed byte sequences.
https://pursuit.purescript.org/packages/purescript-bytestrings
BSD 3-Clause "New" or "Revised" License
9 stars 8 forks source link

Update deps #14

Closed paluh closed 5 years ago

paluh commented 5 years ago

I'm not sure if this is acceptable but purescript-quickcheck is a dependency of purescript-quotient so I've dropped it entirely here.

safareli commented 5 years ago

I'm OK with dropping "purescript-quickcheck": "^5.0.0" but changing version of a dev dependency will have no impact on users, except people developing/working on this lib itself, i.e. once we merge this we wouldn't even need to make a release, so wondering what's the point of this pr (just to make sure i'm not missing anything).

paluh commented 5 years ago

I've messed this PR as quickcheck should stay in deps, because there is Arbitrary instance implemented for ByteString. I'm going to bring back and bump this dependency.

safareli commented 5 years ago

15