search

rightfold / purescript-bytestrings

Immutable packed byte sequences.
https://pursuit.purescript.org/packages/purescript-bytestrings
BSD 3-Clause "New" or "Revised" License
9 stars 9 forks source link

Doesn't webpack #7

Closed kejace closed 7 years ago

kejace commented 7 years ago

It is unclear to me what this line should mean. When I webpack a project depending on purescript-bytestrings, it rightly complains about this line when it is trying to replace the require call with a substitute.

https://github.com/rightfold/purescript-bytestrings/blob/4671936986607bf642b380655241e8f06e4ddd8d/src/Data/ByteString.js#L3

rightfold commented 7 years ago

This line should be deleted, and realGetAtOffset should be updated to take Just and Nothing as arguments.

rightfold commented 7 years ago

Fixed in v5.0.2. Thanks for the report!