search

rightfold / purescript-postgresql-client

https://pursuit.purescript.org/packages/purescript-postgresql-client
BSD 3-Clause "New" or "Revised" License
35 stars 20 forks source link

Check callback for undefined #13

Closed nwolverson closed 6 years ago

nwolverson commented 7 years ago

As of 7.0 pg / 2.0 pg-pool the callback is called with undefined rather than null: https://github.com/brianc/node-pg-pool/blob/master/index.js#L227

ford-prefect commented 7 years ago

I can confirm that this fix is needed.

aabrook commented 6 years ago

Is it possible to have this, or a similar solution, merged and pushed upstream please? It's still an issue.

nwolverson commented 6 years ago

They may just be busy, but I think it's possible @rightfold isn't watching this repo, which is something I unintentionally did myself before. If that's the case, ping :)

rightfold commented 6 years ago

node-postgres has always been a pita, the Main reason I lost interest in this project. It’s weird that I don’t get notifications for new PRs though.

nwolverson commented 6 years ago

Regardless of owning the repository, you only get notifications for PRs/issues if you watch the repo. There's an account setting whether to automatically watch that applies image

rightfold commented 6 years ago

So, another case of GitHub being bad at software development. I question myself why I’m still using this junk.

rightfold commented 6 years ago

Anyways, I’ll tag this merge today and upload it to Pursuit when I have access to a Pulp-enabled machine

paluh commented 6 years ago

@rightfold I'm using this library in production and I quite like its approach to the sql problem. I really want to help maintaining this lib. I'm afraid that I'm not smart enough and Purescript proficient to do this without some supervising.

I understand that you @rightfold are not interested in investing any more time in this code base... or could you give an advice in case of any design doubts?