drewjhart
commented
1 year ago Nice job on the first PR, this is amazing, especially the new components you've created. I left some minor notes and also:
- Checkout markdown on Github for learning better about rich text editing for PR notes and generally anywhere in Github
- It's always nice to include a screenshot of the work when your changes is adding a new UI component or changing the existing behavior. You can even attach a video to your PRs
@cindyqquach @jasonmosley21 Appreciate that you both added some descriptions to the PR - that helps a lot in understanding the changes. Would you also be able to add some screenshots to the description per Mani's comment above? Feel like it makes it a ton easier to understand what the PR is about.
On the RightOnVideo.jsx we have swapped out the current video with the NBC featured video. We've also moved the WhyRightOn down within the LandingPage.jsx. Before:
After:
Then we've added a new Supporters.jsx into the LandingPage.jsx with funder logos. For all the section titles on the Landing Page we reduced the font size and applied a new classname: landing-page-titles
For the Team page, we added new member profiles by adding photos and 3 new blocks in teamData.js We also added an advisor tab to the carousel by editing the teamData.js and the rotating carousel function in ProfileAdvisors.jsx
We also add more media queries to the App.scss and landingPage.scss to fix the responsive of the header, header logo and footer logo size on the tablet screen. Before:
After:
