Make EphemeralLvm::Helper support all EC2 instance types

rightscale-cookbooks / ephemeral_lvm

Configures available ephemeral devices on a cloud server

http://community.opscode.com/cookbooks/ephemeral_lvm

Other

13 stars 16 forks source link

Make EphemeralLvm::Helper support all EC2 instance types #11

Closed sonnysideup closed 10 years ago

sonnysideup commented 10 years ago

This helper module is broken and raises an exception when executing against the m1.small and c1.medium instance types in AWS. This happens because the block device for those instances is named /dev/sda2 (see here) and the current logic does not allow for a numeric suffix.

This PR adds a test to verify the failure and extends the helper to allow for a single digit at the end of the device name.

rs-cookbooks-ci commented 10 years ago

Can one of the admins verify this patch?

arangamani commented 10 years ago

@rs-cookbooks-ci test this please

sonnysideup commented 10 years ago

all good?

arangamani commented 10 years ago

@rs-cookbooks-ci test this please

sonnysideup commented 10 years ago

do you all plan to push a bug release to the community site since this was broken?

douglaswth commented 10 years ago

Yes, we do, but it might not be out until Tuesday.

sonnysideup commented 10 years ago

sounds good, thanks for the heads up

arangamani commented 10 years ago

@drywheat Version 1.0.3 is now published to the community.

sonnysideup commented 10 years ago

great to hear, thank you