search

rightscale-cookbooks / ephemeral_lvm

Configures available ephemeral devices on a cloud server
http://community.opscode.com/cookbooks/ephemeral_lvm
Other
13 stars 16 forks source link

Added option to set owner and group to mount point if present. #21

Closed mauricioalarcon closed 10 years ago

mauricioalarcon commented 10 years ago

Hello,

I couldn't find a way to change the owner/group of the mount point. So I end adding this patch to do it.

I'd like to add some tests and be good citizen here, but I'm not familiar with the process since these are my first 14 lines of ruby. Please be gentle. Is there any other way to achieve the same result?

~M

rs-cookbooks-ci commented 10 years ago

Can one of the admins verify this patch?

douglaswth commented 10 years ago

Could you add the new attributes to the attributes file with default values of nil?

mauricioalarcon commented 10 years ago

Thanks for the comment, I've added the default attribute value.

douglaswth commented 10 years ago

@mauricioalarcon After some more consideration, it doesn't seem like this change makes sense for the cookbook. The ownership of the ephemeral mountpoint is usually going to be root and application specific cookbooks would set up directories under it or modify its permissions rather than this cookbook.

Thank you for your effort. I wish you well in your efforts to learn more about Ruby and Chef. Let me know if you have further questions.

mauricioalarcon commented 10 years ago

@douglaswth Thanks for the insights, after second thought I have to say that you're right. This should be done outside this recipe. I found a simple workaround that solves the issue I was facing and now this patch makes no sense at all.

~M

rs-cookbooks-ci commented 10 years ago

Can one of the admins verify this patch?