search

rightscale-cookbooks / ephemeral_lvm

Configures available ephemeral devices on a cloud server
http://community.opscode.com/cookbooks/ephemeral_lvm
Other
13 stars 16 forks source link

updated to use latest lvm cookbook with di-ruby-lvm-attrib version fi… #39

Closed Stromweld closed 8 years ago

Stromweld commented 8 years ago

…x for latest lvm updates

Stromweld commented 8 years ago

this also resolves issue #38

Stromweld commented 8 years ago

anything I can do to push to get this merged and released to the supermarket?

rshade commented 8 years ago

if you can pin it to cookbook 'lvm', '~> 1.6.1', I can merge it, and look into uploading it

Stromweld commented 8 years ago

I can do that, but why does it need to be pinned? There has been at least twice now that because of pinning we have had to wait for lvm and this cookbook to be updated to fix the di-ruby-lvm-attrib issue after lvm updates. I'd think it'd be better to pin if breaking issues are found and then pin it at that time to older version.

Stromweld commented 8 years ago

made the change to pin to 1.6.1 lvm cookbook

rshade commented 8 years ago

@Stromweld thank you. I prefer pinning as it is a more structured version of dependency management. If you run into issues getting a pull request added in the future, feel free to mention me directly in the pull and I will look at it.

Stromweld commented 8 years ago

are you also working on getting the latest version of this cookbook added to the supermarket?

Stromweld commented 8 years ago

Thanks for the merge too.

cdwilhelm commented 8 years ago

@Stromweld sorry for the delay. ownership of the cookbook has occured and we are working thorough the new release process. Anyway, the new cookbook has been uploaded to the supermarket.

Cheers!

Stromweld commented 8 years ago

cool thanks