search

rightsstatements / rights-app

Web application to serve the rightsstatements.org vocabulary
http://rightsstatements.org/vocab/1.0/
European Union Public License 1.1
1 stars 3 forks source link

Single quote escaping #93

Closed SaschaAdler closed 3 years ago

SaschaAdler commented 3 years ago

updateI18n.sh is updated to escape single quotes, as per the Play Framework documentation. I've also updated it to accept arguments for tx pull, which means that you can use it to only pull the languages you need. I've documented this change in the README.

I've run the app locally and the parameter substitution that was causing a problem earlier appears to be working.

anarchivist commented 3 years ago

Looks good, @SaschaAdler - I'm adding a minor README change and a change to the script to make sure it uses GNU sed on MacOS, then will merge.

SaschaAdler commented 3 years ago

By the way, a +1 for me on deleting .transifexrc from the repo. I don't think tx supports combining data from the repo's .transifexrc and the .transifexrc in your home directory, and so I also had to delete it to pull anything.