F-Droid can't build

[linsui]

In the new flutter app the in_app_review and in_app_purchas are not FOSS. Could you please provide an FOSS flavor without that dependency? I can also patch them out. Thanks!

[rignaneseleo]

Ideally, we need to create a flavor to remove the libraries on the pubspec and on the settings page.

I have never done it, if you have experience with it, just make the changes and send a pull request :)

[linsui]

I'm not a flutter dev. I'll go with a patch for now.

[licaon-kter]

https://gitlab.com/fdroid/fdroiddata/-/jobs/7905139519#L7012

so I bump flutter to 3.24.3 right?

* What went wrong:
Execution failed for task ':flutter_custom_tabs:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR:/home/vagrant/build/it.rignanese.leo.slimfacebook/SlimSocial_for_Facebook/build/flutter_custom_tabs/intermediates/merged_res/release/values/values.xml:204: AAPT: error: resource android:attr/lStar not found.

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/fd3eb5d23b09a27bdf4b30d67428757603e3e97c

[rignaneseleo]

You should compile based on FVM: https://github.com/rignaneseleo/SlimSocial-for-Facebook/blob/master/SlimSocial_for_Facebook/.fvm/fvm_config.json

[linsui]

master? It doesn't make sense... Can you pin the commit?

[rignaneseleo]

What do you mean? Pin the version? Try compiling with stable 3.24.3

[licaon-kter]

We need the exact version that you use, not an ever rolling "master" or "stable".

As already said, 3.24.3 fails...

[rignaneseleo]

I'll change it then, anyway I deployed with these settings:

Flutter 3.24.3 • Dart 3.5.3

== Use Xcode 15.4 ==

sudo xcode-select --switch /Applications/Xcode-15.4.app/Contents/Developer Xcode 15.4 Build version 15F31d

== Use default version of CocoaPods ==

gem list '^cocoapods$' --no-verbose cocoapods (1.15.2)

== Use Java version 17 ==

java -version openjdk version "17.0.11" 2024-04-16 LTS OpenJDK Runtime Environment Zulu17.50+19-CA (build 17.0.11+9-LTS) OpenJDK 64-Bit Server VM Zulu17.50+19-CA (build 17.0.11+9-LTS, mixed mode, sharing)

== Codemagic CLI tools ==

codemagic-cli-tools version codemagic-cli-tools 0.53.9

[licaon-kter]

Note that we saw AAPT: error: resource android:attr/lStar not found. for many apps that updated to the 3.24 Flutter, so it must be an easy fix :)

[rignaneseleo]

Maybe create a branch where you add the following and let me know if it works.

dependencies {
    ...
    implementation "androidx.core:core-ktx:1.6.0"
}

Anyway, I might add fdroid to my codemagic pipeline so they get deployed together. Would you be able to fill a codemagic.yaml for fdroid builds?

[licaon-kter]

Would you be able to fill a codemagic.yaml for fdroid builds?

no idea what that is, so no :shrug: