rigor789 / nativescript-vue-next

MIT License
91 stars 7 forks source link

Compiler tasks #14

Open rigor789 opened 4 years ago

rigor789 commented 4 years ago

Implement template compiler.

rigor789 commented 4 years ago

Ran into a slight block. In Vue 3 the compiler is much smarter about components/native elements. With the DOM we have the default set of html tags that doesn't really change (for vue-dom) but in ns we always have custom elements from plugins. This is not a problem at runtime, as the registerElement calls are already "called". But if we want to compile a template ahead of time (this is what webpack/vue-loader does), we don't know all the elements.

Providing the isCustomElement option to ParserOptions seems like a possible solution (exploring it right now).

Solved in alpha.10 and 49b6f93232f2c29a024b05b1fdf07412a7f53e27

rigor789 commented 4 years ago

Waiting for https://github.com/vuejs/vue-next/commit/20f4965b45d410a2fe95310ecf7293b2b7f46f36 to be released so we can un-comment the tests (they are passing with the above change).

done: 7261b165ef00d654df2e916365acb8b687a7b03b

rigor789 commented 4 years ago

~Adjust compiler options to use decodeEntities Breaking change: https://github.com/vuejs/vue-next/commit/1f6e72b11051561abe270fa233cf52d5aba01d6b~ Resolved by https://github.com/rigor789/nativescript-vue-next/issues/14#issuecomment-612821146

msaelices commented 4 years ago

Just for the record. The breaking change in the previous comment was fixed in this commit: https://github.com/rigor789/nativescript-vue-next/commit/903fb22d77524d7c75d3ed693d6694f5a364f01b

The code is now working with vue-next 3.0.0-alpha.12