search

rii-mango / Daikon

A JavaScript DICOM reader.
Other
220 stars 54 forks source link

Doesn't handle Presentation LUT Shape INVERSE #22

Closed nickhingston closed 6 years ago

nickhingston commented 6 years ago

pixel values are not inverted by the library. They should be...

martinezmj-ims commented 6 years ago

A very similar issue is that it doesn't handles MONOCHROME1 images correctly. I will probably fix both issues in Papaya, but we can keep this issue open until it's resolved there.

nickhingston commented 6 years ago

Super, thanks for the response!

Ah, why is this not a visible issue (on this or Papaya)? are there any other known issues I should know about?!

Personally my preference would be to fix in the decoder - i.e. always have an output that is in the same display format, whatever the input. It will also be much faster to do during the transcoding process itself, rather than running through the byte input twice.

Have you got any MONOCHROME1 examples? I guess it's an easy tweak to #23 PR...

( I have some INVERSE from a customer, but not anonymous so can't post here - happy to share over a private email)