search

riigikogu-kantselei / api

Public issue tracker for Open data API at the Chancellery of the Riigikogu
https://api.riigikogu.ee/
GNU General Public License v3.0
10 stars 0 forks source link

Collective address creation times must have a time zone or time offset #11

Open moll opened 6 years ago

moll commented 6 years ago

Hey,

I'm looking into the collective-addresses endpoint and am thankfully seeing times in ISO 8601 format. However, they're lacking time zones. What time zone are they in and can we get them to include the time offset either as +00:00 or be in UTC with the Z suffix?

This is linked to https://github.com/riigikogu-kantselei/api/issues/3 where I also emphasized the need for time offset or time zones information.

moll commented 5 years ago

This is still a problem with the production API: https://api.riigikogu.ee/api/ It's not clear what time zone/offset the times are in. Local time or UTC time? If local, local to what location? Brussels as we're in the EU? Tallinn? ;)

marmoluik commented 5 years ago

It is not defined, so it is our local time - Tallinn.

moll commented 5 years ago

I strongly recommend you quickly add time offset or a "Z" postfix and use UTC times. Using local times without offset information is fundamentally ambiguous and an anti-pattern. Just think of the moment of daylight saving time cutoff where two identical local times refer to two different global (UTC) times.

moll commented 5 years ago

Hey, I'd still like a response to this. How are we to resolve timestamps that coincide with the daylight saving crossover? We need an offset, otherwise those times refer to two different moments in absolute time.

janesmae commented 5 years ago

This issue has been forwarded to persons responsible. I have notified them once again about this issue. There is not much more I personally can do about this.

moll commented 5 years ago

@janesmae, thanks! Who is responsible for it other than you? I'd like to maybe find out what their priorities and plans are around the API. Our Rahvaalgatus is increasing its dependence on it and its quality and correctness (which this issue is about) matters to properly inform citizens.

janesmae commented 5 years ago

Long story short: the whole planning changes to the API is a task force topic. I personally am not involved in the task force and forwarded your request to the general queue referenced in https://www.riigikogu.ee/avaandmed.

Also, it is vacation season so naturally some issues might take longer at this time of the year.