search

rijentech / bigfastapi

https://bigfastapi.com
7 stars 16 forks source link

[feat]: added store invite functionality 1/2 (sending invite works) #123

Closed teniolafatunmbi closed 2 years ago

teniolafatunmbi commented 2 years ago

@AI-fae

FlorenceEgwu commented 2 years ago

Why do you need a separate user model for store users? I thought a user belongs in a store by default?

Also, you might want to consider following the naming convention for bigfastapi. It's a library meant to be used across different applications. It is important for concepts to maintain consistency for the purpose of clarity

teniolafatunmbi commented 2 years ago

Why do you need a separate user model for store users? I thought a user belongs in a store by default?

Also, you might want to consider following the naming convention for bigfastapi. It's a library meant to be used across different applications. It is important for concepts to maintain consistency for the purpose of clarity

Store users is a table referencing the actual users table but it has other fields in it. Yes, a user belongs to a store, but multiple users can also be in a store. For querying purpose, I will need to fetch store users at some point in time.

About the naming convention, which one did I violate?