search

rik / au-revoir-utm

Removes crappy utm_ tracking stuff
Do What The F*ck You Want To Public License
84 stars 5 forks source link

Forwarding links don't work if URL contains utm parameters? #16

Closed protostork closed 6 years ago

protostork commented 6 years ago

Hi, first-off, great add-on, super useful!

Just a small bug I found - when opening links such as the following in Firefox (which are created by Nuzzel.com's newsletters for example), then au-revoir stops that page from ever loading. When disabling au-revoir the links load normally.

The issue appears to be the last part of the URL that Nuzzel adds- "%26utm_medium%3Demail%26utm_source%3Dnuzzel"

When this string is removed from the URL, it opens as normal.

I.e., http://www.example.org/?%26utm_medium%3Demail%26utm_source%3Dnuzzel

When replacing "%26" with "&", then the link works as normal, even with au-revoir enabled.

Anyone else also experiencing this or any thoughts on what in au-revoir could be causing this?

jarredou commented 6 years ago

same problem with facebook's l.php proxy URL if it contains "utm" data in firefox (57) kind of problematic URLs : "https://l.facebook.com/l.php?u=http%3A%2F%2F [...] _%3Futmcampaign%3D [...]"

The page will apparently load infinitely, but watching the network tab from devtools, no request is sent, and nothing happens.

Manually removing the "utm" junk solved the problem.

rik commented 6 years ago

Can you test with the latest version (1.1.0)? A recent fix should have also fixed this issue.

protostork commented 6 years ago

Wonderful stuff, sorry for the delay hadn't been on Git in a while - it now works! :)

rik commented 6 years ago

Great!