search

rik079 / Speasier

Speak easier in Speasy. A.k.a Sock's Speaking Slave.
https://speasier.rik079.xyz
BSD 3-Clause "New" or "Revised" License
4 stars 2 forks source link

Complete dadjoke.py search function #10

Closed rik079 closed 3 years ago

rik079 commented 3 years ago

I merged #9 for now, because I didn't want to wait for someone more API-savvy then I to pop up, but it still needs to be fixed one day.

Both functions are now basically a copy of each other, with the search one having a warning that the function isn't complete yet. dadjoke.Dadjoke in the first part of the if-statement needs to be changed to a dadjoke.DadjokeSearch() and we have to find a way to deal with the different results that can come up, and pick a random one of them.

Micro-T commented 3 years ago

I'm starting to work on this. We're still using this API correct? https://icanhazdadjoke.com/api#search-for-dad-jokes

rik079 commented 3 years ago

Correct. If you're starting to work on it, please assign the issue to yourself (to indicate that you have 'claimed' it) and add the 'in progress' label to show you're actively working on this right now.