Add error handling for getaddrinfo failing.

rikai / Showbot

🤖 An omnipresent multi-platform bot who's goal in life is become Skynet 🤖

MIT License

40 stars 18 forks source link

Add error handling for getaddrinfo failing. #57

Open rikai opened 8 years ago

rikai commented 8 years ago

03:06:40 irc.1  | [2016/05/22 03:06:40.436] !! /home/rikai/.rvm/gems/ruby-2.3.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:799:in 'initialize': getaddrinfo: Name or service not known (http://jbtitties.com:80) (SocketError)

This looks like crap, lets handle it

cbojar commented 8 years ago

Is this error copied verbatim? In which case, do you see something... funny... about it? Say, maybe in the URL it says it can't find? Perhaps a typo in configuration somewhere?

rikai commented 8 years ago

It's the generic error you get from httpclient when a URL doesn't resolve. It'd be nice to catch it and make it look nice, or supress it i guess, but the former would be preferred.

I'm just in a mood where i'm adding lots of small polish bugs that new contributors or existing contributors wanting to knock off small little things can work on. :100:

cbojar commented 8 years ago

Ah, so that's just a dummy URL. I was wondering about that... :sunglasses:

rikai commented 8 years ago

People in the chatroom being silly :P