JB::AdminPlugin & Admin Refactoring

rikai / Showbot

🤖 An omnipresent multi-platform bot who's goal in life is become Skynet 🤖

MIT License

40 stars 18 forks source link

JB::AdminPlugin & Admin Refactoring #62

Closed eriknelson closed 7 years ago

eriknelson commented 7 years ago

PR for #60

Unblocks #59

s0ph0s-2 commented 7 years ago

I'll update my PR to use the new AdminPlugin, as well as parse the commands in a more conventional way.

rikai commented 7 years ago

Mmm, just a small note or two...

I think "auth" might be more appropriate name for the containing location than "jb".

Secondly, it might be nice for us to start using the locale functionality i've already mostly finished on the web side to start abstracting the text strings out of the plugins.

If you're in the mood to include that work in the PR, it'd be wonderful, but if you're not, i'll accept it anyway. ;)

eriknelson commented 7 years ago

:+1: Will update!

rikai commented 7 years ago

Closes #60