Implement Rate limiting

rikai / Showbot

🤖 An omnipresent multi-platform bot who's goal in life is become Skynet 🤖

MIT License

40 stars 18 forks source link

Implement Rate limiting #63

Open rikai opened 7 years ago

rikai commented 7 years ago

Currently there is no concept of rate limiting in the bot, this needs to be addressed alongside #40.

rikai commented 7 years ago

Turns out cinch has rate limiting already and this too

We just need to add the config option and decide what a good default value is.

s0ph0s-2 commented 7 years ago

Based on the channel modes on #JupiterBroadcasting, I would suggest the following settings:

messages_per_second: 1 (JBot can't send more than half of the messages in any given 5-second window)
server_queue_size: 5 (The hard limit is 10, so half that seems reasonable)

rikai commented 7 years ago

Mmm, keep in mind that JBot also talks in PMs, so this has to account for throughput for that as well, not ONLY the channel.

s0ph0s-2 commented 7 years ago

That's a good point.
However, there haven't been any other suggestions… perhaps we could implement these numbers, then tweak them if they seem too conservative?

rikai commented 7 years ago

Sounds fine to me. 👍

s0ph0s-2 commented 7 years ago

Should I submit a PR that adds these settings to cinchize.yml.example?

rikai commented 7 years ago

Yes please

rikai commented 7 years ago

leaving this open until i can 100% confirm it works. 👍