search

rikbruil / Doctrine-Specification

Doctrine Specification pattern for building queries dynamically and with re-usable classes for composition.
MIT License
50 stars 7 forks source link

Clarify that used Repositories should use / extend the SpecificationRepository #11

Closed holtkamp closed 7 years ago

holtkamp commented 8 years ago

Nice package! Took me some searching to understand that my Repositories need to either:

Maybe a small section about this in the README?

rikbruil commented 7 years ago

I have just merged some changes that add a note to the top of the README.

The requirement to extend SpecificationRepository is gone, you can use a combination of the SpecificationRepositoryTrait and SpecificationAwareInterface in your own custom repository classes now.

The old SpecificationRepository class is still provided for backwards compatibility though (or if you don't mind extending).

holtkamp commented 7 years ago

Great! Closing issue 😉